[train][harbor] Suppress excessive harbor/litellm loggings#987
Merged
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom Feb 4, 2026
Merged
[train][harbor] Suppress excessive harbor/litellm loggings#987CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
CharlieFRuan merged 2 commits intoNovaSky-AI:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to reduce excessive logging from Harbor and LiteLLM. It introduces new configuration flags in default.yaml to suppress Harbor warnings and renames max_episodes to max_turns. For LiteLLM, it adds code to terminal_bench_generator.py to suppress debug info and set the log level. The changes in the YAML configuration are straightforward and look correct. However, the Python change introduces module-level logging configuration, which can cause unintended side effects. I've added a comment with a suggestion to improve this by moving the configuration logic. My review also points out a deviation from the PEP 8 style guide regarding the placement of imports.
skyrl-train/examples/terminal_bench/generator/terminal_bench_generator.py
Show resolved
Hide resolved
CharlieFRuan
added a commit
that referenced
this pull request
Feb 4, 2026
We bump Harbor version (commit hash) so configs added here can be picked up #987 We also add Modal support (mainly environment key passing, which we should get a more sustainable solution and document that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes excessive loggings:
suppress_max_turns_warningandsuppress_override_warningslitellm.suppress_debug_info,set_verbose, and logger level to warning for LiteLLMIn addition, rename max_episodes to max_turns.
Depends on laude-institute/harbor#561